I've been taking pictures for 50 years. It took me a long time to be convinced to switch to digital format...now I believe it is the best, although film cameras still have their place. I am based in Lancaster, PA, but always take lots of photos when on vacation all over the world.
I try to carry my camera with me wherever I go, because 60% of getting a great photo depends upon "being in the right place at the right time." For this reason you can't get as many great photos standing out in the middle of a corn field as you can in Yosemite Valley. (But there are some great ones to be had in the corn field if you look hard enough and wait long enough.) The other 40% depends upon your technical skill with the camera as well as your ability to create a forceful composition.